Java: Use Java 8 map.putIfAbsent and map.computeIfAbsent #8215 #8669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkurniawan07
requested changes
Mar 18, 2018
There was a problem hiding this comment.
@dutta14 do note that the issue at hand is never about using Stream APIs, so refrain from including that kind of change here. Only the changes you proposed in FeedbackResponseCommentSearchDocument.java and InstructorCourseInstructorAbstractAction.java are relevant here, and there are more places where it can be applied.
|
@dutta14 Closing due to inactivity for a long period. Feel free to request for reopen if you're ready to resume the work here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8215
Outline of Solution
Added
putAll(),computeIfAbsentandfilterwhere applicable.