HtmlHelper: fix broken detection of current time #8640 #8746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whipermr5
force-pushed
the
8640-now-detection-stopgap-fix
branch
from
717066a
to
84aeb6f
Compare
wkurniawan07
approved these changes
Apr 2, 2018
wkurniawan07
added
s.ToMerge
Names should not give the impression of containing times when they only contain dates dateTime* -> date* *Now -> *Today *NowMinusOneDay -> *Yesterday *NowPlusOneDay -> *Tomorrow
jacoblipech
pushed a commit
to jacoblipech/teammates
that referenced
this pull request
Apr 3, 2018
jacoblipech
pushed a commit
to jacoblipech/teammates
that referenced
this pull request
May 14, 2018
jacoblipech
pushed a commit
to jacoblipech/teammates
that referenced
this pull request
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stopgap solution for #8640 to get the build to pass until the issue can be properly fixed. Instead of doing time zone detection, recognise all dates within one day from now as the current date to account for time zone differences.