Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9079] Upgrade Angular to 7 #9300

Merged

Conversation

wkurniawan07
Copy link
Member

Part of #9079.

This is a straightforward upgrade and the time is apt since it's been more than 2 months since Angular 7 is upgraded (and less than 4 months to Angular 8!) and our most used libraries bootstrap, tinymce, and handsontable have all supported Angular 7.

@wkurniawan07 wkurniawan07 added this to the V7.0.0-alpha.0 milestone Jan 3, 2019
@wkurniawan07 wkurniawan07 added this to Ongoing in Front-end and RESTful back-end Migration via automation Jan 3, 2019
@wkurniawan07 wkurniawan07 added the s.ToReview The PR is waiting for review(s) label Jan 3, 2019
Copy link
Contributor

@xpdavid xpdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document the generic upgrade guide somewhere?

@wkurniawan07
Copy link
Member Author

wkurniawan07 commented Jan 4, 2019

@xpdavid generic upgrade guide for any Angular n to Angular n + 1? There is no such thing and let's not reinvent the wheel.

@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Jan 4, 2019
@wkurniawan07 wkurniawan07 merged commit aee116e into TEAMMATES:teammatesv7 Jan 4, 2019
Front-end and RESTful back-end Migration automation moved this from Ongoing to Done Jan 4, 2019
@wkurniawan07 wkurniawan07 deleted the teammatesv7-angular7 branch January 4, 2019 10:29
wkurniawan07 added a commit that referenced this pull request Jan 16, 2019
wkurniawan07 added a commit that referenced this pull request Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants