Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#9336] development.md: Fix Firefox E2E setup misinformation #9338

Merged
merged 1 commit into from Jan 18, 2019
Merged

[#9336] development.md: Fix Firefox E2E setup misinformation #9338

merged 1 commit into from Jan 18, 2019

Conversation

amrut-prabhu
Copy link
Contributor

@amrut-prabhu amrut-prabhu commented Jan 18, 2019 •
edited

Fixes #9336

PR Checklist

Ensure that you have:

  • Read and understood our PR guideline: https://github.com/TEAMMATES/teammates/blob/master/docs/process.md#step-4-submit-a-pr
    • Added the issue number to the "Fixes" keyword above
    • Titled the PR as specified in the abovementioned document
  • Made your changes on a branch other than master and release
  • Gone through all the changes in this PR and ensured that:
    • They addressed one (and only one) issue
    • No unintended changes were made
  • Run and passed static analysis: ./gradlew lint and npm run lint
  • Added/updated tests, if changes in functionality were involved
  • Added/updated documentation to public APIs (classes, methods, variables), if applicable

Outline of Solution

Changed "chromedriver executable" to "geckodriver executable" in the Firefox E2E test setup section in development.md

tanhengyeow
tanhengyeow approved these changes Jan 18, 2019
View reviewed changes
Copy link
Member

@tanhengyeow tanhengyeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your first contribution 😄

Feel free to pick a d.Contributors issue to work on after this :)

wkurniawan07
wkurniawan07 approved these changes Jan 18, 2019
View reviewed changes
Copy link
Member

@wkurniawan07 wkurniawan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting the problem and fixing it! 👍

@wkurniawan07 wkurniawan07 changed the title [#9336] development.md: Firefox E2E setup misinformation [#9336] development.md: Fix Firefox E2E setup misinformation Jan 18, 2019
@wkurniawan07 wkurniawan07 merged commit ee180a6 into TEAMMATES:master Jan 18, 2019
@wkurniawan07 wkurniawan07 added the s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging label Jan 18, 2019
@wkurniawan07 wkurniawan07 added this to the V7.0.0-alpha.0 milestone Jan 27, 2019
@wkurniawan07 wkurniawan07 added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkurniawan07 wkurniawan07 wkurniawan07 approved these changes

@tanhengyeow tanhengyeow tanhengyeow approved these changes

Assignees

@tanhengyeow tanhengyeow

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V7.0.0-alpha.0
Development

Successfully merging this pull request may close these issues.

development.md: Fix Firefox E2E setup misinformation
3 participants
@amrut-prabhu @wkurniawan07 @tanhengyeow