Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#9354] Fix path for userMapData.json in sort-usermap.js #9355

Merged
merged 1 commit into from Jan 22, 2019
Merged

[#9354] Fix path for userMapData.json in sort-usermap.js #9355

merged 1 commit into from Jan 22, 2019

Conversation

RonakLakhotia
Copy link
Contributor

Fixes #9354

@RonakLakhotia
Copy link
Contributor Author

Ready for review

tanhengyeow
tanhengyeow approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@tanhengyeow tanhengyeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for pointing out the issue and fixing it :)

@xpdavid
Copy link
Contributor

xpdavid commented Jan 22, 2019 •
edited

@RonakLakhotia Are you going to update the npm run script soon?

@xpdavid xpdavid added the s.Ongoing The PR is being worked on by the author(s) label Jan 22, 2019
@RonakLakhotia
Copy link
Contributor Author

RonakLakhotia commented Jan 22, 2019 •
edited by xpdavid

Should I create a new issue for that? I am working on it currently might take some time

xpdavid
xpdavid approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@xpdavid xpdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xpdavid xpdavid requested a review from damithc January 22, 2019 12:43
@xpdavid xpdavid added s.FinalReview The PR is ready for final review and removed s.Ongoing The PR is being worked on by the author(s) labels Jan 22, 2019
@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Jan 22, 2019
@wkurniawan07 wkurniawan07 changed the title [#9354] Update path of userMapData.json file [#9354] Fix path for userMapData.json in sort-usermap.js Jan 22, 2019
@wkurniawan07 wkurniawan07 merged commit 1c5524d into TEAMMATES:master Jan 22, 2019
@wkurniawan07 wkurniawan07 added this to the V7.0.0-alpha.0 milestone Jan 27, 2019
@wkurniawan07 wkurniawan07 added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkurniawan07 wkurniawan07 wkurniawan07 approved these changes

@xpdavid xpdavid xpdavid approved these changes

@tanhengyeow tanhengyeow tanhengyeow approved these changes

@damithc damithc Awaiting requested review from damithc

Assignees

@tanhengyeow tanhengyeow

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V7.0.0-alpha.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RonakLakhotia @xpdavid @wkurniawan07 @tanhengyeow