[#9382] Migrate remaining of instructor home page/feedback sessions page remind and resend functionals #9422

jacoblipech · 2019-02-10T19:43:22Z

Part of #9382 and fixes #8530

Remind particular students modal to generate students correctly
Bind the buttons together for select all and select all yet submitted
Fixes logic for remind students function
Implement resend students list modal and back end logic
Re-work on the back end tests
Remove old code

…ase modal class

jacoblipech · 2019-02-11T17:42:26Z

@wkurniawan07 Ready for review. I am not sure how to pass the E2E test due to the protected variables in the base class? The UI works as shown

…space between input checkbox and label

…udents response

…ing of variables

…remind requests and rename get student response action

…nd data to backend

… way of populating users

jacoblipech · 2019-02-13T18:37:13Z

@wkurniawan07 Made the necessary changes. Ready for Review

wkurniawan07

Just one minor stuff, ok otherwise.

wkurniawan07 · 2019-02-14T05:43:09Z

src/main/java/teammates/ui/webapi/request/FeedbackSessionStudentSaveRequest.java

+/**
+ * The save request of a list of students from feedback session.
+ */
+public class FeedbackSessionStudentSaveRequest extends BasicRequest {


But this is not a "save" request?

is it better to use remindRequest or submitRequest then?

Which one do you think is better?

I would go with remindRequest.

The submit buttons for both modals states remind. Given that saveRequest is used for the save button and createRequest too. I think remindRequest will be more adequate.

…indRequest

jacoblipech · 2019-02-14T14:01:22Z

@wkurniawan07 Ready for review. Added a text (previously not in v6) to remind and resend links to view results modal to show that there are no students. UI shown below:

Jacob Li Peng Cheng added 8 commits February 9, 2019 03:37

update remind button to only show modal for adding students

90145f1

get the student response status from the back end to populate into table

1bfd2a9

add header and sorting functions for table header

706c66b

add ajax loading capability to students responses

9169c45

returns a list of selected students to remind

9b09046

update styling for remind students modal

7bab068

add testing modules to remind students modal

67fbbda

refactor studentResponseStatus to StudentFeedbackSessionResponseStatus

0bf5d65

jacoblipech changed the title ~~Migrate remaining of instructor home page/feedback sessions page remind and resend functionals~~ [#9382] Migrate remaining of instructor home page/feedback sessions page remind and resend functionals Feb 11, 2019

TEAMMATES deleted a comment from teammates-bot Feb 11, 2019

xpdavid added the s.Ongoing The PR is being worked on by the author(s) label Feb 11, 2019

Jacob Li Peng Cheng added 5 commits February 11, 2019 23:15

refactor methods from remind students modal to extend from a base modal

77867f9

initialise a new resend results link modal component to extend from b…

2b148db

…ase modal class

implement resend published results link to students functions

6224c28

adjust remind feedback submission link logic

e345d24

adjust remind students feedback session logic

fce2d02

jacoblipech force-pushed the instructor-home-page-remind branch from f0563c5 to 92c986a Compare February 11, 2019 16:53

Jacob Li Peng Cheng added 2 commits February 12, 2019 00:56

update test case for feedback session remind and resend results link

5f04f32

update test to retrieve student submission response

8cf66a4

jacoblipech force-pushed the instructor-home-page-remind branch 2 times, most recently from 4196b92 to 8cf66a4 Compare February 11, 2019 17:09

jacoblipech and others added 4 commits February 12, 2019 01:09

Merge branch 'master' into instructor-home-page-remind

20ba6f4

remove migrated action files

2491879

remove additional migrated action test files

d6ac9d5

fix trailing comma check style

797214e

jacoblipech requested a review from wkurniawan07 February 11, 2019 17:42

jacoblipech added s.ToReview The PR is waiting for review(s) and removed s.Ongoing The PR is being worked on by the author(s) labels Feb 11, 2019

wkurniawan07 added this to the V7.0.0-beta.0 milestone Feb 13, 2019

jacoblipech added 10 commits February 13, 2019 10:01

add resend link function to `sessions-table-component

eb518d3

remove additional dot, fix alignment and add a form-check to add a …

cfec5b0

…space between input checkbox and label

update httpRequestService to get from remind submission to session st…

33c640d

…udents response

backend transfer data files into the webapi.output package

fb45004

frontend transfer of data files into api-output to populate and renam…

72fafdf

…ing of variables

handle backend logic for using getAndValidateRequestBody to handle …

f763df6

…remind requests and rename get student response action

handle front end logic to use FeedbackSessionStudentSaveRequest to se…

3866b7a

…nd data to backend

update remind result and remind submission action tests to handle new…

6e9e3b2

… way of populating users

remove migrated java and jsp files

502b1b4

additional: add a clickable class to make dropdown menu mouse to change

3131b9e

jacoblipech force-pushed the instructor-home-page-remind branch from 9b76846 to 3131b9e Compare February 13, 2019 17:56

wkurniawan07 added s.ToReview The PR is waiting for review(s) and removed s.Ongoing The PR is being worked on by the author(s) labels Feb 14, 2019

wkurniawan07 self-requested a review February 14, 2019 03:23

wkurniawan07 requested changes Feb 14, 2019

View reviewed changes

jacoblipech added 4 commits February 14, 2019 16:57

Merge branch 'master' into instructor-home-page-remind

c96804c

Merge branch 'master' into instructor-home-page-remind

58893db

rename FeedbackSessionStudentSaveRequest to FeedbackSessionStudentRem…

fab9687

…indRequest

add a message to handle no students being enrolled

5431d6e

jacoblipech force-pushed the instructor-home-page-remind branch from a5608ff to 5431d6e Compare February 14, 2019 13:42

jacoblipech force-pushed the instructor-home-page-remind branch 2 times, most recently from 722667b to 5431d6e Compare February 14, 2019 17:34

wkurniawan07 approved these changes Feb 15, 2019

View reviewed changes

wkurniawan07 merged commit 7745139 into TEAMMATES:master Feb 15, 2019

Front-end and RESTful back-end Migration automation moved this from Ongoing to Done Feb 15, 2019

wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Feb 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#9382] Migrate remaining of instructor home page/feedback sessions page remind and resend functionals #9422

[#9382] Migrate remaining of instructor home page/feedback sessions page remind and resend functionals #9422

jacoblipech commented Feb 10, 2019 •

edited

jacoblipech commented Feb 11, 2019

jacoblipech commented Feb 13, 2019

wkurniawan07 left a comment

wkurniawan07 Feb 14, 2019

jacoblipech Feb 14, 2019

wkurniawan07 Feb 14, 2019

jacoblipech Feb 14, 2019

jacoblipech commented Feb 14, 2019 •

edited

[#9382] Migrate remaining of instructor home page/feedback sessions page remind and resend functionals #9422

[#9382] Migrate remaining of instructor home page/feedback sessions page remind and resend functionals #9422

Conversation

jacoblipech commented Feb 10, 2019 • edited

jacoblipech commented Feb 11, 2019

jacoblipech commented Feb 13, 2019

wkurniawan07 left a comment

Choose a reason for hiding this comment

wkurniawan07 Feb 14, 2019

Choose a reason for hiding this comment

jacoblipech Feb 14, 2019

Choose a reason for hiding this comment

wkurniawan07 Feb 14, 2019

Choose a reason for hiding this comment

jacoblipech Feb 14, 2019

Choose a reason for hiding this comment

jacoblipech commented Feb 14, 2019 • edited

jacoblipech commented Feb 10, 2019 •

edited

jacoblipech commented Feb 14, 2019 •

edited