[#9480] Add snapshot test for instructor search page #9581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrtheonlyone
changed the title
monmanuela
requested changes
Mar 19, 2019
...nstructor/instructor-search-page/__snapshots__/instructor-search-page.component.spec.ts.snap
Show resolved
Hide resolved
|
|
||
| exports[`InstructorSearchPageComponent should snap with a student table 1`] = ` | ||
| <tm-instructor-search-page | ||
| fbSessionDataTables={[Function Array]} |
There was a problem hiding this comment.
You should populate this too for one of the test cases
There was a problem hiding this comment.
Interestingly this is not being used in the html template itself
There was a problem hiding this comment.
I think that part is still under migration? @wkurniawan07
...nstructor/instructor-search-page/__snapshots__/instructor-search-page.component.spec.ts.snap
Show resolved
Hide resolved
|
Hi @monmanuela / @AyushChatto , this page is still under migration. I have done a bare bones snapshot test for the currently available components. Do see if it is okay. |
AyushChatto
reviewed
Mar 26, 2019
| }); | ||
|
|
||
| it('should snap with a feedback session table', () => { | ||
|
|
There was a problem hiding this comment.
Just one qn - why is this one blank?
There was a problem hiding this comment.
Sry, this was a KIV. I have removed it!
rrtheonlyone
force-pushed
the
course-search-snapshot
branch
from
749daae
to
060c672
Compare
rrtheonlyone
force-pushed
the
course-search-snapshot
branch
from
060c672
to
af7bf84
Compare
wkurniawan07
added
s.ToMerge
wkurniawan07
added this to Ongoing
in Front-end and RESTful back-end Migration
via automation
wkurniawan07
moved this from Ongoing
to Done
in Front-end and RESTful back-end Migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9480
Added a few simple test cases for the instructor search page.