[#9480] Add snapshot test for student list component

[rrtheonlyone]

Part of #9480

Added some test cases for the student list component.

No data
Populate with data
Check if data has sections
Check with some fields hidden

[AyushChatto]

Add cases for :-

• enableRemindButton set to true
• student with photoUrl
• isAllowedToModifyStudent set to true

[rrtheonlyone]

Added the respective cases @AyushChatto
(except for photoUrl - that one will be removed after #9575)

[AyushChatto]

LGTM as far the coverage is concerned. Had some qns about the snapshot though, but I might be wrong. Best to err on the side of caution I suppose.

[AyushChatto]

Really minor nit, but there's actually two students that are yet to join.

[rrtheonlyone]

Yup updated!

[AyushChatto]

Next time, make life easier for reviewers by giving the hidden students names like 'This should not be displayed' :(

[rrtheonlyone]

Well, I am not writing this test to make life easier for reviewers. I have fed in data that you are more likely to see in production for this application. I have preferably tried to make it as real as possible (so we are more likely to catch bugs).

As a reviewer, you could have looked out for:

    component.listOfStudentsToHide = [
      'alice.b.tmms@gmail.tmt',
      'tester@tester.com',
    ];

From there you would have to make sure that the student with this email, is not going to be present in this snapshot.

It is definitely a little bit more work and I agree that names like 'This should not be displayed' would have made things a little faster (its also not super critical to have names like Alice). I can change this if you prefer but personally, I would stick to data that is as close to production if I could.

If you follow a pattern like this, you may end up compromising the quality of your tests at some point..but again this is just my own opinion! I am okay either way :)

[AyushChatto]

Just basing it off #9605 - I haven't traditionally follow it either, but I kinda see the merit in it. No worries, this is fine, just for future reference anyway :)

[rrtheonlyone]

I have improved as per the suggestions. @AyushChatto have a look when you have time.

[AyushChatto]

LGTM :)

[wkurniawan07]

LGTM