Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#9382] Add support for Msq type questions #9628

Merged
merged 19 commits into from Apr 8, 2019
Merged

[#9382] Add support for Msq type questions #9628

merged 19 commits into from Apr 8, 2019

Conversation

RonakLakhotia
Copy link
Contributor

Part of #9382

@RonakLakhotia RonakLakhotia added the s.Ongoing The PR is being worked on by the author(s) label Mar 31, 2019
@RonakLakhotia RonakLakhotia added s.ToReview The PR is waiting for review(s) and removed s.Ongoing The PR is being worked on by the author(s) labels Apr 4, 2019
@RonakLakhotia
Copy link
Contributor Author

RonakLakhotia commented Apr 7, 2019 •
edited

@wkurniawan07 ready for review

wkurniawan07
wkurniawan07 requested changes Apr 7, 2019
View reviewed changes
Copy link
Member

@wkurniawan07 wkurniawan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly ok

...onents/question-types/question-edit-details-form/msq-question-edit-details-form.component.ts Outdated Show resolved Hide resolved
...onents/question-types/question-edit-details-form/msq-question-edit-details-form.component.ts Outdated Show resolved Hide resolved
...mponents/question-types/question-edit-answer-form/msq-question-edit-answer-form.component.ts Outdated Show resolved Hide resolved
src/main/java/teammates/common/datatransfer/questions/FeedbackMsqResponseDetails.java Outdated Show resolved Hide resolved
src/main/java/teammates/common/datatransfer/questions/FeedbackMsqResponseDetails.java Outdated Show resolved Hide resolved
@RonakLakhotia
Copy link
Contributor Author

@wkurniawan07 updated changes.

wkurniawan07
wkurniawan07 approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@wkurniawan07 wkurniawan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wkurniawan07 wkurniawan07 removed the s.ToReview The PR is waiting for review(s) label Apr 8, 2019
@wkurniawan07 wkurniawan07 added the s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging label Apr 8, 2019
@RonakLakhotia RonakLakhotia merged commit 4cf91c0 into TEAMMATES:master Apr 8, 2019
@wkurniawan07 wkurniawan07 added this to the V7.0.0-beta.0 milestone Apr 10, 2019
@wkurniawan07 wkurniawan07 self-assigned this Apr 10, 2019
@wkurniawan07 wkurniawan07 added this to Ongoing in Front-end and RESTful back-end Migration via automation Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damithc damithc damithc left review comments

@wkurniawan07 wkurniawan07 wkurniawan07 approved these changes

Assignees

@wkurniawan07 wkurniawan07

Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
No open projects
Front-end and RESTful back-end Migration
  
Done
Milestone
V7.0.0-beta.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RonakLakhotia @damithc @wkurniawan07