New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#9560] JMeter GUI Test Plan (JMX) for Admin Authentication, AddInstructor, L… #9655
[#9560] JMeter GUI Test Plan (JMX) for Admin Authentication, AddInstructor, L… #9655
Conversation
Hi @paramvir1994 , welcome to TEAMMATES :) Thanks for taking the time to make this contribution! In the future, it would be good if you could indicate your interest as a comment in the issue before implementing the fix, as stated in our contributor process guide 😅 Here are some things that you should take note if you are still interested in working on this (if not, you can look at first timer issues too:
I haven't gotten a chance to look at your work in this PR yet, but I'll take a look at it soon. Let me know if you want any further clarifications :) Edit: I looked at the |
Hi @amrut-prabhu , Thank you for your valuable comment. :) Actually, I wasn't expecting anyone else to be working on this issue. Also, I didn't see any comments from anyone else so I assumed I should pick up the issue directly. My bad about that. To clarify, while I was continuing working on this, I saw your commit and then I realized the whole process has been changed. Earlier, Jmeter GUI test plan creation was supposed to be done when I just started working on it. Hence, I believe the work I did is invaluable for the project now. Regarding the Jmeter test plan that I worked upon, I had hardcoded the values that are static such as URL webpage address(for example- /web/admin/home). All the dynamic values that can impact the whole script are abstracted out (for example- hostname, port number). Also, I implemented the capturing of CSRF token dynamically using Regular Expression Extractor. Being a newbie in Jmeter, I was in learning mode and tried to implement it in an efficient way. Well, now the process is changed and I would love to further contribute using Jmeter API and TestNG. If you have anything specific regarding the change in the Jmeter Script I provided, please let me know and I will update the script accordingly. |
@paramvir1994 Apologies for the delayed response.
There are other dynamic values to be considered like logged in user, name of the course, feedback session etc. Take a look at the process followed in the 2 tests that we have right now- InstructorStudentEnrollmentLNPTest and StudentProfileLNPTest (keep an eye on #9652 too). Honestly, since you do not have much experience with JMeter, and since this L&P project is still in its infancy stage, I think that it would be best if you try working on some other issues first. If you still want to work on this, you can take up one of the tasks in #9646 (let us know first!), but do note that these are more difficult than the ones that have been completed. Or you can propose some other endpoint that you want to work on (like retrieving sessions for the sessions page) and justify why you think it would be performance issue prone. |
Part of #9560
The issue #9561 mentioned to use Jmeter GUI for creation of test plan. I planned to contribute on this issue and it covers the following:
Steps for execution:
Things to be worked upon: