Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9480] Add snapshot tests for instructor course student details page #9680

Conversation

AyushChatto
Copy link
Contributor

Part of #9480

Seems pretty minimal, so I'm not even sure if this needs snapshot testing. But I added

  • Default
  • Populated student

Just to make sure it's rendered correctly.

@AyushChatto AyushChatto changed the title Add snapshot tests [#9480] Add snapshot tests Apr 19, 2019
@TEAMMATES TEAMMATES deleted a comment from teammates-bot Apr 19, 2019
@TEAMMATES TEAMMATES deleted a comment from teammates-bot Apr 19, 2019
@TEAMMATES TEAMMATES deleted a comment from teammates-bot Apr 19, 2019
@AyushChatto AyushChatto changed the title [#9480] Add snapshot tests [#9480] Add snapshot tests for instructor course student details page Apr 19, 2019
@AyushChatto AyushChatto added the s.ToReview The PR is waiting for review(s) label Apr 19, 2019
@AyushChatto AyushChatto force-pushed the instructorCourseStudentDetailsSnapshot branch from 53bfb4b to af300fe Compare April 19, 2019 00:28
Copy link
Contributor

@monmanuela monmanuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AyushChatto AyushChatto added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Apr 19, 2019
Copy link
Member

@wkurniawan07 wkurniawan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Apr 21, 2019
@AyushChatto AyushChatto merged commit e3b1f52 into TEAMMATES:master Apr 21, 2019
rrtheonlyone pushed a commit to rrtheonlyone/teammates that referenced this pull request Apr 21, 2019
@wkurniawan07 wkurniawan07 added this to the V7.0.0-beta.0 milestone Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants