Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#9674] - Remove unused variables in Const.java #9692

Merged
merged 4 commits into from May 8, 2019
Merged

[#9674] - Remove unused variables in Const.java #9692

merged 4 commits into from May 8, 2019

Conversation

hppranaav
Copy link
Contributor

Fixes #9674

Removed all unused variables in file Const.java

@hppranaav
[#9674] - Remove unused variables in Const
85682a1 
removed all unused variables in file Const.java
@RonakLakhotia RonakLakhotia added the s.ToReview The PR is waiting for review(s) label Apr 22, 2019
ChooJeremy
ChooJeremy requested changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@ChooJeremy ChooJeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 360 unused variables removed 👍

You're missing the following:
QUOTA_PER_ENROLLMENT_EXCEED
ENROLL_LINE_EMPTY
ENROLL_LINES_PROBLEM

Once those are removed too I think this should be good to go.

src/main/java/teammates/common/util/Const.java Outdated Show resolved Hide resolved
@ChooJeremy ChooJeremy self-assigned this Apr 22, 2019
@ChooJeremy ChooJeremy added s.Ongoing The PR is being worked on by the author(s) and removed s.ToReview The PR is waiting for review(s) labels Apr 22, 2019
@hppranaav
Update Const.java
41041f9 
Removed the unused variables 

QUOTA_PER_ENROLLMENT_EXCEED
ENROLL_LINE_EMPTY
ENROLL_LINES_PROBLEM
@hppranaav
Copy link
Contributor Author

@ChooJeremy Thank you for reviewing my request!!. I have incorporated the requested changes in my latest commit.

@ChooJeremy
Copy link
Contributor

What about UNREGISTERED_STUDENT_MESSAGE? Once you remove UNREGISTERED_STUDENT and UNREGISTERED_STUDENT_RESULTS, this variable becomes unused too.

@hppranaav
Update Const.java
d36871d 
Removed the unused variable 

UNREGISTERED_STUDENT_MESSAGE
ChooJeremy
ChooJeremy approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@ChooJeremy ChooJeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChooJeremy ChooJeremy added s.FinalReview The PR is ready for final review and removed s.Ongoing The PR is being worked on by the author(s) labels Apr 23, 2019
wkurniawan07
wkurniawan07 approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@wkurniawan07 wkurniawan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@wkurniawan07 wkurniawan07 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels May 7, 2019
@ChooJeremy ChooJeremy merged commit 4829386 into TEAMMATES:master May 8, 2019
@wkurniawan07 wkurniawan07 added this to the V7.0.0-beta.0 milestone Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChooJeremy ChooJeremy ChooJeremy approved these changes

@wkurniawan07 wkurniawan07 wkurniawan07 approved these changes

Assignees

@ChooJeremy ChooJeremy

@wkurniawan07 wkurniawan07

Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V7.0.0-beta.0
Development

Successfully merging this pull request may close these issues.

Remove unused variables in Const.ResourceURIs
5 participants
@hppranaav @ChooJeremy @wkurniawan07 @RonakLakhotia @amrut-prabhu