Fixed blank space in mobile view #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for tecoding ready! 🔨 Explore the source changes: 865574a 🔍 Inspect the deploy log: https://app.netlify.com/sites/tecoding/deploys/6105ff71e858e60008b1143e 😎 Browse the preview: https://deploy-preview-45--tecoding.netlify.app/ |
Before approving:
|
Testers templateNote: Please be as specific as possible, include version numbers
|
|
Device model: Xiaomi Redmi Note 8
|
|
Device model: Samsung A50
|
AlonsoMtzG
approved these changes
Aug 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38
Causes:
Mobile browsers have a search bar on top of the screen, which is calculated for the viewport metrics, using 100vh works on desktop, but not on mobile browsers due to this. A workaround is to use
position: fixedwhich is the setting used here.Learn more in this link