-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEI address element is wrongly converted to HTML address element #261
Comments
Ill bet there are plenty of places where html:address is used for its formattibg effect only. And where it really corresponds to something like tei:trailer |
Where can the html:address appear or not? What are the constraints on it? I would agree that the fall back for tei:address is html:span with a class='address' makes sense since most of the places tei:address is allowed seem to be phrase-level. When you are rendering metadata (e.g. when ancestor::publicationStmt) then perhaps it makes sense to be doing something different with it, but surely that depends on whatever it is we're doing with publicationStmt in our teitohtml at the moment? |
html:address can appear anywhere flow content is allowed (I know that's vague, but I can't find anything more specific). Here's a useful page on it: https://www.w3.org/wiki/HTML/Elements/address I think the semantic issues are more significant than the validation issues, although I first came across this through a validation problem in one of our test outputs. |
The Stylesheets co-op group looked at this and decided that in html_core.xsl, the output from
That should mean that the output appearance should not change from what it now is, but the invalidity issues should go away. Two other issues came up, which will get separate tickets. One issue that remains for this ticket: are there contexts (such as |
See Martina's pull request here: Looks good to go -- as soon as anyone has the time to handle the expected-results fallout, do pull it! |
TEI address element is wrongly converted to HTML address element (#261)
I'm reviewing XSLT Stylesheets tickets, and saw we have at least a partial fix here thanks to @martinascholger . Where are we with this? |
We may be finished with this: Tasks to double-check:
|
F2F Group: Pull request looks good. Questions: Should all TEI address elements be processed in this way? Check how we want |
F2F: publicationStmt use of |
The purpose of the HTML
<address>
element is very precise and constrained:The TEI
<address>
element is much more generic, and appears all over the place, containing the addresses of people in personographies, places in gazetteers, and so on. However, the Stylesheets (in particular html/html_core.xsl, line 95) simply converts the TEI<address>
to the HTML<address>
, which is both semantically wrong and often invalid (because the range of contexts allowing the HTML address is quite constrained).We need to decide on another default rendering approach for generic addresses (
<span class="address">
?) for most contexts, and also we need to see if we can figure out when an address would be a good candidate for conversion to the HTML<address>
element (for instance when it's associated with a document author, a publisher, an editor, or something like that).The text was updated successfully, but these errors were encountered: