makegraphicsanttask needs at least documentation, if not improvement

[sydb]

While looking at #477, @dmj’s improved processing of @facs when generating ant copy-the-graphics tasks, a few things occurred to me:

1. I, for one, had almost no idea what the culprit program (tools/makegraphicsanttask.xsl) is for, who would call it when and why. Reading the code it looks like it reads in a TEI file and writes out an ANT project. But I should not have to read the source … where is this thing documented? (Or at least if I do read the source, the header comment should tell me.)
2. It (tools/makegraphicsanttask.xsl) only processes @facs attributes that are on <pb> elements. Since I do not know who is calling this program or why, I cannot say whether that is right or wrong, but it is certainly suspicious.
3. It seems to mess up if an image file is listed as just an absolute path reference, e.g. <pb facs="/tmp/path/to/page2.png"/> (the resulting copy/@file is empty).
4. It seems to mess up even worse if there is whitespace around an absolute path reference, e.g. <pb facs=" /tmp/path/to/page4.png"/>.
5. It does not seem to handle multiple values.

[JanelleJenstad]

This is set to status: Go to figure out what this program is for and who calls it. Until we know what it's for, we can't fix it. @MegJBrown Pls discuss with @sydb at your next standing mtg.

[martindholmes]

The process is called twice from teianttasks.xml, once from buildodt and once from builddocx.

[martinascholger]

It seems that at least the documentation is missing.