Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subset setup #448

Merged
merged 3 commits into from
Jul 7, 2020
Merged

Subset setup #448

merged 3 commits into from
Jul 7, 2020

Conversation

martindholmes
Copy link
Contributor

Implementation by @sydb and me of our decisions during the meeting 2020-07-03 on build circularity.

sydb added 3 commits July 3, 2020 12:04
Add new directory, source/, which for now has only 1 file, the p5subset against which these Stylesheets should be tested.
(tar cf - lib teioo.jar) | (cd ${PREFIX}/share/xml/tei/stylesheet; tar xf - )
(cd release/xsl; tar cf - .) | (cd ${PREFIX}/share; tar xf -)
mkdir -p ${PREFIX}/bin
cp bin/transformtei ${PREFIX}/bin
cp --preserve=timestamps bin/transformtei ${PREFIX}/bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why preserve the timestamp?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raffazizzi Good question, and we had a good reason, but I can't remember it. @sydb?

Copy link
Member

@hcayless hcayless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. In the Stylesheets meeting we discussed adding a message to transformtei that gives the current version of the p5subset used instead of the warning message that a remote copy will be retrieved. I will open an issue for that.

@hcayless hcayless merged commit 6fcd499 into dev Jul 7, 2020
@peterstadler peterstadler deleted the subsetSetup branch September 14, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants