Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech/@type should not have a closed value set #1662

Closed
martindholmes opened this issue Jul 6, 2017 · 9 comments
Closed

tech/@type should not have a closed value set #1662

martindholmes opened this issue Jul 6, 2017 · 9 comments
Assignees

Comments

@martindholmes
Copy link
Contributor

The <tech> element has a closed value list for @type:

light|sound|prop|block

http://www.tei-c.org/release/doc/tei-p5-doc/en/html/ref-tech.html

This is a very limited list, and working on a current project we're finding other values we need to use, such as "video", "house" and more.

It seems unreasonable for this to be a closed value list, especially as performance norms and technologies are in constant change. Could we make it suggested values instead? This would not invalidate any existing documents.

@sydb
Copy link
Member

sydb commented Jul 6, 2017

While I note that @type of <tech> has been a closed list since P2 (<tech> did not exist in P1), I can see no reason why it should be closed, rather than semi. I’m in favor of changing this.

@hcayless
Copy link
Member

hcayless commented Jul 6, 2017

Agreed.

@martindholmes
Copy link
Contributor Author

It should be a member of att.typed too.

@emylonas
Copy link
Contributor

the class membership regularization is part of #386

@sydb sydb self-assigned this Jan 19, 2018
sydb added a commit that referenced this issue Jan 19, 2018
Per #1662 change the value list of the type attribute of <tech> to 'semi'.
@sydb
Copy link
Member

sydb commented Jan 19, 2018

Done at 023aaea. Note that I just changed the list to semi, not part of att.typed, which is (as @emylonas just pointed out) another ticket which probably can’t be handled before upcoming release.

@martindholmes
Copy link
Contributor Author

Can't it just be added to the class? That shouldn't affect anything, surely?

@sydb
Copy link
Member

sydb commented Jan 19, 2018

It’s not hard, @martindholmes, but you have to both add it to the class and then override it and then test that it all went OK. Since (in theory) we are supposed to enter the refrigerator tonight, and I’m working on a couple of other things, I thought it best to keep it simple for now, knowing it would be hit in that other ticket anyway.

@martindholmes
Copy link
Contributor Author

Sorry, didn't realize the freeze as so soon.

@sydb
Copy link
Member

sydb commented Jan 19, 2018

No worries! (Our fault for waiting until the last minute … :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants