-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple sibling remarks in the same language cause translation issues #1872
Comments
XPath to find instances: for $r in //remarks return
if ($r/preceding-sibling::remarks[@xml:lang=$r/@xml:lang] and
not (following-sibling::remarks/@xml:lang = $r/@xml:lang) and
$r/@xml:lang = 'en')
then $r else () |
I'm in favour of solution 2. |
@martinascholger I agree with you. @sydb favours number 1. |
I don't see how having multiple paragraphs inside a single remark, would solve the problem of correspondence between paragraph |
@duncdrum The sequence of paragraphs is fixed, so the first para in the English should match the first para in the translation. If there are different numbers of paragraphs, then the translation is out of date or wrong and should be fixed. In the case of separate |
@martindholmes why does sequence matter, if we have a pair of |
@duncdrum In some cases where there are multiple English It's going to be a bit tedious to add and maintain all the ids and pointers for the majority of cases when the problem only exists for nine files, so I prefer the simple option mainly for that reason. If we also decide to encourage the use of multiple individual But please have a look at the specific cases and see if you can make a clear argument for how they differ from multi-paragraph |
Coming a bit late to the party, but solution #2 gets my vote too. The extra baggage of trying to align translation equivalences is just not worth the effort. It's not done anywhere else, so why gild this particular lily? |
F2F Graz agrees that there should be 1 remark per language with paragraphs. @martindholmes to implement for these few cases, then add a Schematron rule to enforce it. |
This got green for go in the meeting; the commits above, ending with #5d776c0ec, should have completed the collapsing of the remarks. Thinking of the Schematron to catch this, though, I'm pretty sure we only want to apply it to the P5 specs, not to everyone else's ODDs, so I need to check with Council about the best way to write Schematron that applies only to our spec files. Setting this back to Needs Discussion. |
Per @sydb added Schematron to p5odds.odd in commit #54f4d2278. When build has run and the rule is tested, the ticket can be closed. |
Tested and working. |
@sydb and I have been looking at a few cases where there are multiple
<remarks>
elements in English in spec files. There are nine cases of this:This causes problems for translation because there is no direct connection between each English
<remarks>
and its other language equivalent, so it's not easy to tell when a given translation is out of date.It is also apparent that the decision on whether to create multiple remarks versus having multiple paragraphs in a single
<remarks>
is not particularly consistent.There are two possible solutions to this:
Link each English
<remarks>
to its other-language equivalents using@xml:id
and@corresp
.Have a rule that only one
<remarks>
element for each language is allowed, and use multiple paragraphs inside the single<remarks>
to distinguish different topics (which is already done in many cases).The text was updated successfully, but these errors were encountered: