Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad examples for definition of org/@role #1908

Closed
TomazErjavec opened this issue Jul 25, 2019 · 3 comments
Closed

Bad examples for definition of org/@role #1908

TomazErjavec opened this issue Jul 25, 2019 · 3 comments
Assignees

Comments

@TomazErjavec
Copy link

The definition of <org>, https://www.tei-c.org/release/doc/tei-p5-doc/en/html/ref-org.html says, for the definition of its @role attribute:

Values for this attribute may be locally defined by a project, using arbitrary keywords such as artist, employer, family group, or political party...

But @role is defined as "1–∞ occurrences of teidata.word separated by whitespace", so 2 examples are wrong, they should be e.g. "family_group", "political_party".

@jamescummings
Copy link
Member

jamescummings commented Jul 25, 2019

Fixed (in near record time) this corrigible error, but it raises the question in my mind as to whether the datatype should really be teidata.enumerated. Making status:needs discussion for council to consider that aspect.

https://jenkins.tei-c.org/job/TEIP5-dev/lastSuccessfulBuild/artifact/P5/release/doc/tei-p5-doc/en/html/ref-org.html

@MegJBrown
Copy link
Contributor

Council is greenlighting James's suggestion to change datatype to be teidata.enumerated.

@martinascholger martinascholger added this to the Guidelines 4.1.0 milestone Jun 14, 2020
@martinascholger
Copy link
Member

implemented with b5f948c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants