Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example will scare people #1964

Closed
sydb opened this issue Jan 28, 2020 · 16 comments
Closed

example will scare people #1964

sydb opened this issue Jan 28, 2020 · 16 comments

Comments

@sydb
Copy link
Member

sydb commented Jan 28, 2020

As much as I really liked it, the <egXML> for the @type of <desc> should probably be changed before the next release.

@lb42
Copy link
Member

lb42 commented Jan 29, 2020

It should be burned with fire. I must have missed the memo about deprecating teiCorpus though I dont think I am alone in that. If ever there was a P6 change, this is it.

@sydb
Copy link
Member Author

sydb commented Jan 29, 2020

Well that’s part of the point. <teiCorpus> is not being deprecated. So to have an example that suggests it is …

@ebeshero
Copy link
Member

@sydb What can we think of immediately that really is deprecated? (I have the file open right now and thought I might just do an edit...) The problem with an example with deprecation information in it is that it will always become dated if it's a real example from the TEI that gets really deprecated and goes away...

@ebeshero
Copy link
Member

ebeshero commented Jan 29, 2020

To be fair, the example does have a validUntil date of 2027-10-20! That's a whole seven years away!

@laurentromary
Copy link
Contributor

Than let's put 3030 as a year. That will be optimal :-)

@ebeshero
Copy link
Member

ebeshero commented Jan 29, 2020

@sydb Here's a relatively recent deprecation notice (advising people to use <empty/> in <content>.--Should we just use this? https://www.tei-c.org/release/doc/tei-p5-doc/en/html/DEPRECATIONS.html

@sydb
Copy link
Member Author

sydb commented Jan 29, 2020

I don’t like that one, @ebeshero, because not everyone writes ODDs or can wrap their heads around the idea that the <content> element is declaring the allowable content of its the element being declared by its parent <elementSpec>.

So we should look back a bit further (which was trivial in Subversion and can’t be that difficult in Git), or perhaps just make up a fanciful one?

<desc type="deprecationInfo">The <gi>GB</gi> element will
  no longer be allowed inside the <gi>EU</gi> element
  as of <subst>
    <del><date when="2019-03-29">29 Mar 19</date></del>
    <add><date when="2020-01-31">31 Jan 20</date></add>
  </subst>. Instead use either the <gi>deal</gi> or <gi>noDeal</gi>
  element.</desc>

Hmmm … alright, looking back into the Guidelines a bit further is probably a good idea.

@lb42
Copy link
Member

lb42 commented Jan 29, 2020

The point about examples is that, as far as possible, they should either represent real existing data, or make clear that they do not. The problem with the current example is that it does not do either, and just extending the deprecation date while an amusing joke for the inner circle of cognoscenti will just confuse anyone else. Syd's jokey Brexit example would be OK (I have no objection to humour), but for me at least it is in really bad taste. But surely to goodness it's not hard to find/invent a plausible and inoffensive one?

@lb42
Copy link
Member

lb42 commented Jan 29, 2020

Current examples you could consider:
quotation/@Form
shift/@new
teiHeader/@type

@sydb
Copy link
Member Author

sydb commented Jan 29, 2020

The problem with quotation/@form and teiHeader/@type is they do not actually have a <desc type="deprecationInfo">. (That’s because those deprecations happened before we invented "deprecationInfo".) And I don’t see a current deprecation of shift/@new.

We could certainly use one of them as the basis for an example, but that runs the risk of running afoul of @lb42’s useful distinction that examples should be real or obviously not.

So either someone has to come up with a better fanciful example than my Brexit one (which I never intended be actually used, BTW), or someone should search through recent previous releases for examples of desc[@type="deprecationInfo"]. Any volunteers?

@sydb
Copy link
Member Author

sydb commented Jan 30, 2020

Well, not surprisingly (since deprecationInfo is so new) I only found two. The aforementioned <empty/> one and this:

    <desc type="deprecationInfo" versionDate="2018-09-14"
    xml:lang="en">Several standards bodies, including NIST in the USA,
    strongly recommend against ending the representation of a number
    with a decimal point. So instead of <q>3.</q> use either <q>3</q>
    or <q>3.0</q>.</desc>

@ebeshero
Copy link
Member

@sydb That's an improvement--quite clear and neither divisive nor baffling! Maybe it will do for this example?

@sydb
Copy link
Member Author

sydb commented Jan 30, 2020

I don’t really like it much, but I like it a lot better than what we have now. :-) And you’re right, it’s clear and not scary. So unless someone comes up with something better soon, I think we go for it. Thanks @lb42 and @ebeshero !
@raffazizzi has not assigned this ticket to anyone yet, but if no one has done this by this Sat 01 Feb, I will assign it to myself and just do it.

@ebeshero
Copy link
Member

@sydb It's easier than the ticket I'm staring at, so I might just do this one instead this evening. . .

@ebeshero ebeshero self-assigned this Jan 30, 2020
@ebeshero
Copy link
Member

I'm working on this one right now...

@ebeshero
Copy link
Member

@sydb I've updated the example--if it looks okay, let's close this.

@sydb sydb closed this as completed in b97d669 Jan 30, 2020
hcayless pushed a commit that referenced this issue Jun 26, 2022
hcayless pushed a commit that referenced this issue Jun 26, 2022
hcayless pushed a commit that referenced this issue Jun 26, 2022
Put final touches on @ebeshero's new example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants