Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing @mode='add' to overridden @types with valLists per issue #2128 #2129

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

martindholmes
Copy link
Contributor

@martindholmes martindholmes commented Mar 28, 2021

This PR fixes issue #2128: 21 cases of valLists which needed @mode="add" and checked the results; no impacts on the test suite.

@sydb
Copy link
Member

sydb commented Mar 29, 2021

I still have reservations that these should all be "change", not "add", but

  • Whereas there is no consensus on the matter; and
  • Whereas @martindholmes is strongly in favor of "add"; and
  • Whereas it should not be difficult to switch to "change" in the future should we change our minds; and
  • Whereas we would like to get an interim release out as early as possible …

I am hereby merging this in the hopes that the 4.2.0 (and 4.2.1) release techs can get an interim release out sooner rather than later.

@sydb sydb merged commit 2af4b57 into dev Mar 29, 2021
@JanelleJenstad
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants