Fix Epub3 Fileextension bug #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Stadler <stadlerpeter@yahoo.fr>
…for the Docker image Signed-off-by: Peter Stadler <stadlerpeter@yahoo.fr>
modularized servlets
|
ok, so this will be a new release (v1.1.1), right? I'll test the current dev branch regarding the actual issue #36 and will report back here asap. If anyone else (@joeytakeda) wants to test this too, please go ahead and add your review :) |
|
I tried the supplied test files in #36 and some other test files and they had the correct fileextension, forgot to add that here :) |
peterstadler
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
just tested issue #36 with the current image at ghcr.io/teic/teigarage:dev and I can confirm that the "ePub"-suffix is properly added and Apple Books happily opens the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #36