New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oxygen 24.1 breaks transforms because we have Saxon 9 hard-coded #54
Comments
This works for Oxygen 24.1; will enlist other users to test for earlier versions. |
@martindholmes fix looks good to me, we did the same thing in the TEI .framework files bundled with Oxygen 24.1 |
Thanks @raducoravu. I'll close this then. :-) |
@martindholmes Also all transformation scenarios in the "teip*.framework" files which contained references to:
need to be changed to contain references to:
I'm attaching the changes we made in the TEI framework files in Oxygen 24.1 |
@raducoravu If I replace the original log4j with this collection, will things still work with older versions? I'm not sure how your patching has been done, but if someone is using (say) Oxygen 20, will they still need to have the original log4j path as well as these new ones, or have all recent Oxygens been updated to the replacement log4j files above? |
@martindholmes indeed if you want the framework to work with any Oxygen version you would need to leave the reference to:
and add the other references to the new logging jars used in Oxygen 24.1 instead of replacing the old reference to the log4j jar with them. |
Thanks @raducoravu. If it's OK with you I'm going to ask you to check over my pull request before I merge the changes. |
Now complete. |
Many of the standard transformations defined in our frameworks have:
<String>${oxygenHome}/lib/*saxon*9*.jar</String>
However, Oxygen 24.1 ships with Saxon 10, and now has the Saxon lib as:
oxygen-patched-saxon-10.jar
I'm going to try adding that alongside the existing one, so we maintain backwards compatibility, and see if that fixes it.
The text was updated successfully, but these errors were encountered: