Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove records from "Compare Selected" #798

Closed
VlitS opened this issue Mar 21, 2020 · 4 comments
Closed

Remove records from "Compare Selected" #798

VlitS opened this issue Mar 21, 2020 · 4 comments

Comments

@VlitS
Copy link
Contributor

VlitS commented Mar 21, 2020

Currently when you are looking at multiple records using "Compare Selected", if you want to remove a record from the compare you have to deselect it and then start a new compare.

Would it be possible to add a "Remove from Compare" option to the context menu when you right click on the column header?

@fireundubh
Copy link
Contributor

Ctrl+Click the highlighted records in the tree that you want to stop comparing.

@VlitS
Copy link
Contributor Author

VlitS commented Mar 21, 2020

I already tested that. You then have to Right Click -> Compare Selected again, as doing so ends the compare, unless you are under your set limit for auto-compare.

In any case, this would be most useful for large compares where finding by column is quicker than looking for the relevant record in the left pane.

@fireundubh
Copy link
Contributor

In the dev-4.1.4 build:

  • Cannot reproduce with selected records less than auto compare limit. Using Ctrl+Click to deselect records while below the limit will remove those records from the comparison view.
  • Reproduced with selected records greater than auto compare limit.
  • Additional issue: Using Ctrl+Click to deselect records while above the limit will reset the comparison and show only the deselected record in the view.
  • Additional issue: The auto compare limit is equal to limit-1, so a limit of 10 means that only 9 records can be auto compared. This should be equal to limit.

@VlitS
Copy link
Contributor Author

VlitS commented Mar 21, 2020

For the limit-1 thing, that is because of the wording. Currently the option says:

Auto "Compare Selected" when multi-selecting less than ___ records

So if you are changing it to make it auto-compare up to the number entered (which I will agree is probably a little more intuitive, in my experience people are more used to less than or equal to than less than by itself), you need to also change the text. Maybe change it to

Auto "Compare Selected" up to ___ records

ElminsterAU added a commit that referenced this issue Mar 30, 2020
#798: fixed issue where Ctrl+Click could not bypass wbAutoCompareSelectedLimit
ElminsterAU added a commit that referenced this issue Apr 3, 2020
#804: fixed issue where previously merged fix for #798 introduced node selection issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants