Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FO4 but likely also everything else] Quick Auto Clean should force-enable "Remove OFST Data" #959

Closed
Evan555alpha opened this issue Sep 12, 2021 · 4 comments

Comments

@Evan555alpha
Copy link
Contributor

What is the version of xEdit you are using?
4.0.3h hotfix 1

Describe the bug
Quick Auto Clean will write zeroed out OFST data if the option "remove OFST Data from Worldspace" is unchecked, causing crashes with the game.

To reproduce
Disable removal of OFST data in the options panel
Run QAC on a plugin that has OFST data, such as a DLC Masterfile
Load in-game
Crash game

Expected behavior
QAC should either force-enable the previously mentioned option, or otherwise include removing OFST data - at least on all official DLC files - as part of the cleaning process, since cleaning them will change offsets, making the original OFST data invalid.

Additional context
I mention only doing it to all the official DLC files, as I'm sure that out there somewhere, there's a plugin that as OFST data that otherwise doesn't need cleaning, and removing OFST data would be kinda pointless if it is correct.

@ElminsterAU
Copy link
Collaborator

No. It will write unchanged OFST data if the option is unchecked.

@ElminsterAU
Copy link
Collaborator

Nobody should ever disable that. The option shouldn't exist at all.

@Evan555alpha
Copy link
Contributor Author

Unchanged OFST data is still incorrect OFST data if the file has been changed (at least with children being removed from WRLD, anyway)
Yes, and I am suggesting this as a failsafe, not a reason to continue to keep that option.

ElminsterAU added a commit that referenced this issue Nov 7, 2021
@ElminsterAU
Copy link
Collaborator

Should be fixed with commits referenced above.

The option doesn't exist in the UI at all anymore. It can only be triggered now by passing the -dontremoveoffsetdata command line parameter. Which will be ignored if used together with quick clean or quick auto clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants