Handle sv_password changes with the log listener #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: password is still checked regularly via the server verifier timer. Eventually, this change will allow us to remove that. But for now that verifier job also serves the purpose of making sure that the server is still alive, so it has been left in tact until a better solution for server liveliness checks is implemented.
gpittarelli
added a commit
that referenced
this pull request
Jan 11, 2016
Handle sv_password changes with the log listener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: password is still checked regularly via the server verifier
timer. Eventually, this change will allow us to remove that. But for now
that verifier job also serves the purpose of making sure that the server
is still alive, so it has been left in tact until a better solution for
server liveliness checks is implemented.
This requires TF2Stadium/TF2RconWrapper#8 to be merged first, the tests are expected to fail until then.