Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies to latest versions #210

Merged
merged 4 commits into from
May 8, 2023
Merged

Conversation

JJ-8
Copy link
Collaborator

@JJ-8 JJ-8 commented Mar 24, 2023

I have done an upgrade of all dependencies of both the frontend and the backend. This fixes all dependency vulnerabilities in the project according to yarn audit.

The graphql-upload packages has been swapped with graphql-upload-ts, because it is not possible anymore to use graphql-upload due to import issues with TypeScript. Graphql-upload-ts is an drop-in replacement with even less dependencies so less code that can break!

I have tested almost all functionalities of CTFNote by hand and had no issues.

This PR is a successor of #206.

The graphql-upload packages has been swapped with graphql-upload-ts,
because it is not possible anymore to use graphql-upload due to import issues.
The SCSS variables are from quasarframework/quasar#15144 (comment)
This fixes the ugly dark shadows in dark mode but keeps the shadows in light mode.
This was added in Quasar 2.11 but reverted using the SCSS patch.

Due to an update of ESLint, it complains about single-word components.
Since this is used in CTFNote, this rule is disabeld.

Also some small (automatic) fixes.
It expects undefined officially, so we return that instead.
@JJ-8 JJ-8 requested review from XeR and SakiiR and removed request for XeR March 24, 2023 20:07
@JJ-8 JJ-8 mentioned this pull request Mar 24, 2023
@JJ-8 JJ-8 mentioned this pull request May 7, 2023
@XeR XeR self-assigned this May 8, 2023
Copy link
Contributor

@XeR XeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 months ago

Oops… LGTM

@XeR XeR merged commit 4671681 into TFNS:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants