Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/genconst.awk broken #300

Closed
TG9541 opened this issue Apr 13, 2020 · 3 comments
Closed

tools/genconst.awk broken #300

TG9541 opened this issue Apr 13, 2020 · 3 comments
Assignees
@TG9541
Labels
bug

Comments

@TG9541
Copy link
Owner

TG9541 commented Apr 13, 2020

Problems with pre-release 2.2.24.pre2 revealed that tools/genconst.awk handles constants defined with RamWord incorrectly. The error was likely introduced in 978e01a.
@TG9541 TG9541 self-assigned this Apr 13, 2020
@TG9541 TG9541 added the bug label Apr 13, 2020
@TG9541
Copy link
Owner Author

TG9541 commented Apr 13, 2020

I did a number of tests and also added the target board that generated the constant to the comment.

@TG9541 TG9541 closed this as completed in d5ee888 Apr 13, 2020
TG9541 added a commit that referenced this issue Apr 13, 2020
@TG9541
Merge pull request #301 from TG9541/fixgenconst
d17684d 
Fixes #300: fix for genconst.awk
@TG9541
Copy link
Owner Author

TG9541 commented Apr 13, 2020

The most important damage from this bug broke was the 'IDLE handler address constant in the target folder.

@TG9541 TG9541 mentioned this issue Apr 13, 2020
Closed
@TG9541
Copy link
Owner Author

TG9541 commented May 22, 2020

While not really a solution for the tools integrity problem, #309 should at least detect bugs that break 'IDLE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TG9541 TG9541

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TG9541