Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codeload.py: improve serial line target response and error handling #394

Closed
TG9541 opened this issue Jan 24, 2021 · 0 comments
Closed

codeload.py: improve serial line target response and error handling #394

TG9541 opened this issue Jan 24, 2021 · 0 comments
Assignees
@TG9541
Labels
tools

Comments

@TG9541
Copy link
Owner

TG9541 commented Jan 24, 2021

In serial mode codeload.py has always had difficulties with a target response that contained more than one LF (e.g. due to test output). In telnet mode it uses the Python telnet.expect() method which is more robust than Python serial.port.readline(). Python serial.port.read_until() should be more flexible.

Also error information is not as helpful as it should be.
@TG9541 TG9541 self-assigned this Jan 24, 2021
@TG9541 TG9541 added the tools label Jan 24, 2021
@TG9541 TG9541 closed this as completed in 5cd3415 Jan 24, 2021
TG9541 added a commit that referenced this issue Jan 24, 2021
@TG9541
Merge pull request #395 from TG9541/python3
d430ce9 
fixes #394 codeload.py: improve serial line target response and error…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TG9541 TG9541

Labels
tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TG9541