Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nag message appears in MS if user doesn't have correct permissions #43

Closed
thomasgriffin opened this issue Oct 10, 2011 · 4 comments
Closed
Milestone

Comments

@thomasgriffin
Copy link
Contributor

The nag message for installing the plugin still appears (even when the plugin is installed) for multisite users without the correct permissions.

@GaryJones
Copy link
Member

And so it should, for a required plugin - it perhaps needs a different message, one that advises them to contact their administrator to request that the missing plugin be installed.

@thomasgriffin
Copy link
Contributor Author

It should disappear though, when the plugin is installed. However the nag message is still appearing even though the plugin is installed.

@thomasgriffin
Copy link
Contributor Author

Ok, so just pushed up a fix to address a part of this issue. In dealing with roles and capabilities (which is a new field for me in WP, never worked with multisite until tonight), only using the _get_plugin_basename_from_slug function within the admin menu causes issues for users without the permission to see the menu, namely undefined indexes (which makes sense since file_path is actually never populated). I addressed this by adding that same line into the nag message area, which doesn't make any effect on those that can already see the menu, but removes undefined index errors for those that can't.

Now, what I don't get is how I am still able to see the message and the link to the plugin admin page. I've setup an account as an admin for the networked site (but not super admin). I can't see the Plugins menu, so I figure install_plugins should be sufficient, but apparently it isn't. Gonna try to see how I can get this bug fixed. If you have multisite experience, good, because I don't. :)

@thomasgriffin
Copy link
Contributor Author

I know this is a bug to be addressed, but I am hoping the dismissable notices feature will help alleviate this some. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants