Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue in plugin listing page after 2.6.0 #587

Closed
ernilambar opened this issue May 17, 2016 · 4 comments
Closed

Issue in plugin listing page after 2.6.0 #587

ernilambar opened this issue May 17, 2016 · 4 comments
Labels
Type: Bug

Comments

@ernilambar
Copy link

When I update TGM to 2.6.0 I got following in the plugin install page.
In this line, https://github.com/TGMPA/TGM-Plugin-Activation/blob/develop/class-tgm-plugin-activation.php#L2726 when %1$s is changed to %s, issue is resolved.

Screenshot - http://prnt.sc/b50e6w
jrfnl added a commit that referenced this issue May 17, 2016
@jrfnl
Use the correct placeholder in action link strings.
e9924f9 
Issue introduced in #516.

Fixes #587
@jrfnl jrfnl mentioned this issue May 17, 2016
Merged
@jrfnl
Copy link
Contributor

jrfnl commented May 17, 2016

Hi @ernilambar Thanks for reporting this. Would you mind testing out PR #588 to see if I fixed it correctly ?

@ernilambar
Copy link
Author

@jrfnl Yes, I tried that PR and it worked as expected.

@jrfnl
Copy link
Contributor

jrfnl commented May 17, 2016

Great! Thanks for testing.

@jrfnl
Copy link
Contributor

jrfnl commented May 19, 2016

FYI: we just released v 2.6.1 which contains the fix for this issue. Website & Custom Generator will be updated within the next few hours.

@jrfnl jrfnl mentioned this issue May 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrfnl @ernilambar