Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Remove call to deprecated function screen_icon() #244

Merged
merged 1 commit into from Jan 11, 2015

Conversation

NateWr
Copy link
Contributor

@NateWr NateWr commented Jan 6, 2015

The call to these functions trigger a REQUIRED error in Theme Check, which prevents themes using this library to be submitted to the .org repository. They are unnecessary and were wrapped in a check for WordPress < 3.8 anyway.

This resolves #234.

@NateWr
Copy link
Contributor Author

NateWr commented Jan 6, 2015

It also resolves issue #224.

@bfintal
Copy link

bfintal commented Jan 11, 2015

+1

@thomasgriffin We really need this merged with master

thomasgriffin added a commit that referenced this pull request Jan 11, 2015
* Remove call to deprecated function screen_icon()
@thomasgriffin thomasgriffin merged commit e61b32f into TGMPA:master Jan 11, 2015
@jrfnl
Copy link
Contributor

jrfnl commented Jan 12, 2015

Can this please also be merged to develop ?

GaryJones pushed a commit that referenced this pull request Apr 22, 2015
Manually re-applied to develop branch due to merge conflict after applying to master branch.

props @NateWr, see #244, fixes #234
@GaryJones
Copy link
Member

Now merged into develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants