Fix notice appearing in WP 4.3-alpha #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to WordPress/WordPress@4c0c7fd, WP 4.3 now expects `$this->_column_headers` property in the list table object to have 4 entries. This commit fixes the offset notice that otherwise appears. In 4.2, the `list()` call inside `single_row_columns()` simply drops the extra values, so it's backwards compatible.
|
@jrfnl Any clue why we might be manually populating the |
jrfnl
added a commit
that referenced
this pull request
Jun 6, 2015
Fix notice appearing in WP 4.3-alpha
At first glance - because the normal way of populating it involves screen object related functions ( |
|
This may be one we can address in 3.0.0 then. |
|
We do need to have something left to do after 3.0 as well though ;-) |
|
Looks like there is some fall-out from this: |
|
Should be fixed by PR #432 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to WordPress/WordPress@4c0c7fd, WP 4.3 now expects
$this->_column_headersproperty in the list table object to have 4 entries. This commit fixes the offset notice that otherwise appears.In WP 4.2, the
list()call insidesingle_row_columns()simply drops the extra values, so this is backwards compatible.