Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds greater shot ingestions flexibility #213

Merged
merged 15 commits into from
Jun 6, 2023
Merged

Conversation

markspec
Copy link
Contributor

@markspec markspec commented May 18, 2023

Resolves #211.

  • Adds "AutoChannelWrap" option to grid_overrides this ingests "type B" data as "type A" by mapping lowest channel index to 1 for each cable.
  • Adds integration tests for shot reading. This uses segyio to create simple segy records for ingestions. (4x test with "a" and "b" ingested with and without "AutoChannelWrap"
  • Adds grid_overrides support to CLI tool.
  • Refactored grid overrides with a command design pattern.

@tasansal
Copy link
Collaborator

My changes from #212 broke some of your logic but should be easy to fix :) Let me know if you need any help.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #213 (db30fa2) into main (c956c75) will increase coverage by 0.81%.
The diff coverage is 80.27%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   80.99%   81.80%   +0.81%     
==========================================
  Files          43       45       +2     
  Lines        1710     1913     +203     
  Branches      272      308      +36     
==========================================
+ Hits         1385     1565     +180     
- Misses        287      311      +24     
+ Partials       38       37       -1     
Impacted Files Coverage Δ
src/mdio/commands/segy.py 0.00% <0.00%> (ø)
src/mdio/converters/segy.py 76.25% <ø> (+5.00%) ⬆️
src/mdio/segy/_workers.py 17.94% <0.00%> (ø)
src/mdio/segy/exceptions.py 42.30% <37.50%> (+42.30%) ⬆️
src/mdio/segy/geometry.py 75.70% <75.70%> (ø)
src/mdio/segy/parsers.py 98.00% <100.00%> (+0.12%) ⬆️
src/mdio/segy/utilities.py 87.50% <100.00%> (+22.91%) ⬆️
tests/conftest.py 100.00% <100.00%> (ø)
tests/integration/conftest.py 100.00% <100.00%> (ø)
tests/integration/test_segy_import_export.py 100.00% <100.00%> (ø)

@tasansal tasansal merged commit 2eb78dd into TGSAI:main Jun 6, 2023
@markspec markspec mentioned this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Greater Shot Ingestion Flexibility
3 participants