Refactor SEG-Y standard registration and retrieval and make it more strict #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trict. The SEG-Y standard registration method and retrieval method have been renamed for clarity. Now, they are called "register_segy_standard" and "get_segy_standard" respectively. Also, the 'SegyStandard' property for 'SegyDescriptor' and all its references is updated which can be None. This change makes the codebase more consistent and the behavior more predictable when working with SEG-Y standard objects.
The 'segy_revision' method in SegyFactory and 'segy_standard' in SegyInfo schema now allow None type. The conditional expression to handle non-zero SEG-Y revision in SegyFactory has also been adjusted accordingly. This refactoring acknowledges potential cases where SEG-Y standard value might not be defined.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
- Coverage 94.18% 94.15% -0.03%
==========================================
Files 38 38
Lines 1582 1574 -8
Branches 193 193
==========================================
- Hits 1490 1482 -8
Misses 70 70
Partials 22 22 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SEG-Y standard registration method and retrieval method have been renamed for clarity. Now, they are called
register_segy_standardandget_segy_standard. Also, theSegyStandardproperty forSegyDescriptorand all its references is updated which can beNone. This change helps with custom schemas and makes the numbering more strict.We only allow
{0.0, 1.0, 2.0, 2.1, None}as values now.