Improved advertisement support #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for advertisements in the default UI, and polishes the existing ad components.
<theoplayer-time-range>now has an extrashow-ad-markersattribute. When set, yellow ad markers are shown on the progress bar to indicate when the content will be interrupted by an advertisement.<theoplayer-ad-skip-button>and<theoplayer-ad-clickthrough-button>are always hidden. This is necessary, because Google IMA doesn't provide a way to hide its own built-in buttons. Unfortunately, this means you can't use custom buttons for these when using IMA. 馃槥<theoplayer-default-ui>now has a reworked ad control bar, taking up less space and showing fewer controls. This is necessary to leave enough space for Google IMA's own buttons.