Support ads while casting to Chromecast #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattiasBuelens
requested review from
georgechoustoulakis,
jorisfluyt and
Jeroen-Veltmans
Jeroen-Veltmans
approved these changes
Jan 30, 2024
jorisfluyt
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THEOplayer 6.8.0 added support for playing advertisements while connected to Chromecast. This PR makes Web UI aware of that.
This mostly already worked, except that the ad clickthrough button wasn't visible on desktop. We now always show that button if you're casting, regardless of whether you're on desktop or mobile. I tweaked the CSS of that button, so its height doesn't change when it switches from "skip in X seconds" to "skip".
I also added a fullscreen button to the ad UI, in case you would want to play your ads fullscreen. 馃槢