Fix ui.player.destroy()
#62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web UI wasn't correctly removing all its event listeners when THEOplayer is destroyed through
ui.player.destroy()(whereuiis a<theoplayer-default-ui>or<theoplayer-ui>). This caused a whole bunch of errors when those event listeners fire while the player is being destroyed.React UI now calls
player.destroy()during unmount, if for some reason that didn't happen yet. (Normally, this happens automatically when the custom element is disconnected from the DOM.)Fixes #59