Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement OpenID Connect and SAML 2.0 #336

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

Implement OpenID Connect and SAML 2.0 #336

wants to merge 19 commits into from

Conversation

SamuelWei
Copy link
Collaborator

@SamuelWei SamuelWei commented Apr 17, 2023 •
edited

Fixes #300

Fixes #20

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current masters head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Refactor LDAP Auth
  • Add OpenID Connect
  • Add SAML 2.0

@SamuelWei SamuelWei mentioned this pull request Apr 20, 2023
Merged
6 tasks
This was referenced Apr 28, 2023
Closed
Closed
@codecov
Copy link

codecov bot commented Jul 3, 2023 •
edited

Codecov Report

Patch coverage: 7.03% and project coverage change: -8.23% ⚠️

Comparison is base (fb0b2fc) 95.80% compared to head (79d811f) 87.58%.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #336      +/-   ##
============================================
- Coverage     95.80%   87.58%   -8.23%     
- Complexity      932     1043     +111     
============================================
  Files           155      167      +12     
  Lines          3340     3680     +340     
============================================
+ Hits           3200     3223      +23     
- Misses          140      457     +317
Files Changed Coverage Δ
app/Auth/OIDC/InvalidConfiguration.php 0.00% <0.00%> (ø)
app/Auth/OIDC/NetworkIssue.php 0.00% <0.00%> (ø)
app/Auth/OIDC/OIDCController.php 0.00% <0.00%> (ø)
app/Auth/OIDC/OIDCProvider.php 0.00% <0.00%> (ø)
app/Auth/OIDC/OIDCUser.php 0.00% <0.00%> (ø)
app/Auth/SAML2/Saml2Controller.php 0.00% <0.00%> (ø)
app/Auth/SAML2/Saml2Provider.php 0.00% <0.00%> (ø)
app/Auth/SAML2/Saml2User.php 0.00% <0.00%> (ø)
app/Models/Session.php 50.00% <0.00%> (-50.00%) ⬇️
app/Models/SessionData.php 0.00% <0.00%> (ø)
... and 8 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelWei
Merge branch 'master' of github.com:THM-Health/PILOS into 300-impleme…
79d811f 
…nt-oidc

# Conflicts:
#	resources/js/views/App.vue
@SamuelWei SamuelWei changed the base branch from master to develop October 16, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
PILOS 3.0
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement OIDC as an alternative to LDAP Implement shibboleth sso authentication
1 participant
@SamuelWei