Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server pooling #99

Merged
merged 18 commits into from
Feb 4, 2021
Merged

Add server pooling #99

merged 18 commits into from
Feb 4, 2021

Conversation

SamuelWei
Copy link
Collaborator

@SamuelWei SamuelWei commented Jan 12, 2021

Fixes #96

Type (Highlight the corresponding type)

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current masters head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Added server pools
  • Added attribute name to servers
  • Added server pools to room types
  • Changed load balancer to only use servers from the server pool of the room's room type
  • Adjusted tests

Other information

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #99 (77a34b2) into master (ed9642a) will increase coverage by 0.92%.
The diff coverage is 95.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #99      +/-   ##
============================================
+ Coverage     85.54%   86.47%   +0.92%     
- Complexity      426      456      +30     
============================================
  Files           131      139       +8     
  Lines          2401     2610     +209     
  Branches        150      163      +13     
============================================
+ Hits           2054     2257     +203     
- Misses          292      294       +2     
- Partials         55       59       +4     
Impacted Files Coverage Δ Complexity Δ
resources/js/views/rooms/View.vue 35.05% <ø> (ø) 0.00 <0.00> (ø)
resources/js/views/settings/servers/View.vue 92.53% <ø> (ø) 0.00 <0.00> (ø)
app/Server.php 93.04% <50.00%> (-0.24%) 33.00 <2.00> (-1.00)
resources/js/router.js 81.42% <77.77%> (-0.54%) 0.00 <0.00> (ø)
resources/js/views/settings/serverPools/Index.vue 92.50% <92.50%> (ø) 0.00 <0.00> (?)
resources/js/views/settings/serverPools/View.vue 93.87% <93.87%> (ø) 0.00 <0.00> (?)
resources/js/views/settings/roomTypes/View.vue 94.11% <95.83%> (+4.92%) 0.00 <0.00> (ø)
app/Http/Controllers/api/v1/RoomController.php 99.05% <100.00%> (ø) 29.00 <0.00> (ø)
app/Http/Controllers/api/v1/RoomTypeController.php 100.00% <100.00%> (ø) 8.00 <0.00> (ø)
app/Http/Controllers/api/v1/ServerController.php 100.00% <100.00%> (ø) 22.00 <0.00> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed9642a...89825b0. Read the comment docs.

@SamuelWei SamuelWei marked this pull request as ready for review January 27, 2021 15:01
@SamuelWei SamuelWei requested a review from dsst95 January 27, 2021 15:10
@SamuelWei SamuelWei requested a review from dsst95 February 4, 2021 11:45
@dsst95 dsst95 merged commit b827ec2 into master Feb 4, 2021
@dsst95 dsst95 deleted the 96-server-pooling branch February 4, 2021 17:57
@SamuelWei SamuelWei mentioned this pull request Mar 4, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server pooling
2 participants