Mod: Alert UI Change (#84) #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibcylon
commented
Jun 29, 2024
Comment on lines
+77
to
+92
| timerActiveTrigger | ||
| .debug("\(indexPath) active") | ||
| .drive(cell.activateCardSubject) | ||
| .disposed(by: cell.disposeBag) | ||
|
|
||
| Driver.just(item) | ||
| .drive(cell.rx.user) | ||
| .disposed(by: cell.disposeBag) | ||
|
|
||
| self?.viewModel.pulse(\.$timeState) | ||
| .asDriverOnErrorJustEmpty() | ||
| .withLatestFrom(timerActiveTrigger) { ($0, $1) } | ||
| .filter { _, isActive in isActive } | ||
| .map { timeState, _ in timeState } | ||
| .drive(cell.rx.timeState) | ||
| .disposed(by: cell.disposeBag) |
There was a problem hiding this comment.
활성화 해야할 id와 tiem의 id를 비교하여 Bool값 만들고 cell에 바인딩하였습니다.
시간을 cell에 바인딩해야하는데 state 필터링을 어디에서 하는게 좋을까요?
A. 지금처럼 VC에서 Cell에 바인딩하는 시점
B. Cell 내부에서 state를 가지고 필터링
| animated: true | ||
| ) | ||
| TFLogger.ui.debug("scroll to Item at: \(indexPath)") | ||
| case let .scrollAfterDelete(user): |
There was a problem hiding this comment.
- ViewModel(Reactor)로부터 삭제 명령이 오면
- 먼저 Cell transfrom animation을 수행하고,
- cell animation 종료 completion에서 다시 signal 보냄
- vm state에서 모델 제거
| self.likeImageView.isHidden = isHidden | ||
| } | ||
|
|
||
| private func addGradientLayer() { |
There was a problem hiding this comment.
gradient 한 번 생성 후 캡처해놨다가 재사용
| // MARK: pageControl | ||
| func createLayout() -> UICollectionViewLayout { | ||
| let sectionLayout: NSCollectionLayoutSection = .horizontalListSection() | ||
| sectionLayout.visibleItemsInvalidationHandler = { [weak self] (items, offset, environment) in |
There was a problem hiding this comment.
@Minny27
compositional Layout에서
pageControl 값 변경하려면, sectionLayout의 변경 감지 closure에서 값 계산하여 control에 연결
|
|
||
| final class TFCarouselView: TFBaseView { | ||
|
|
||
| lazy var carouselView = TFBaseCollectionView(frame: .zero, collectionViewLayout: createLayout()) |
There was a problem hiding this comment.
@Minny27
페이지컨트롤과 컬렉션 뷰를 가지고 있는 케로셀 뷰를 컴포넌트로 분리
ChaNoo97
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation ⍰
Key Changes 🔑
구조 부분
파일 부분
UI 부분
To Reviewers 🙏🏻
예를 들어 유저 인터렉션 없이, 내부 state 변경으로 인해서 Cell UI를 띄어야하는 상황이 오면,
A. 부모 Reactor가 Cell쪽으로 Action을 보내는지
아니면
B. 부모 Reactor가 Cell 거치지 않고, 바로 Cell Reactor에게 직접적으로 Action을 보내는지 궁금합니다.
[src](
Linked Issue 🔗