-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Contribution] Script for making the necessary files for a new model #86
Conversation
Update repo
@cenyk1230 Hello, the issues raised by Travis are not from parts I added. Am I expected to fix them for my pull request to be accepted? Let me know if that's the case. Thank you |
Hi @Sahandfer, I have fixed the issues with the code in the master. Please wait for the re-run. |
@Sahandfer Nice job. But I wonder whether the template model should be also tested. |
Thank you @cenyk1230! I think the template files I created serve as an interface for new models to be added; since they don't have any logic or calculations within them, I don't see it as necessary to test them. However, one improvement that I can think of is modifying the templates in the future after establishing a global style for cogdl models. |
Hi @Sahandfer, I think maybe the template files can be moved to a new folder such as |
Hello @cenyk1230, I think that's a great suggestion. I have moved the two templates to a new template folder and they are now called: base_model and base_example. I have also updated the script to use these templates. |
@Sahandfer It seems that you moved the wrong model file. I think you should |
@cenyk1230 Sorry for that. I fixed my mistake; however, the coverage has decreased but I'm not sure what the reason for that is. Thank you and sorry for the trouble. |
Well done! |
I've made a script for making the necessary files for a new model that:
The script can be tested by