Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding DropEdge GCN model #88

Merged
merged 14 commits into from
Dec 18, 2020
Merged

Adding DropEdge GCN model #88

merged 14 commits into from
Dec 18, 2020

Conversation

JiaYiLiJayee
Copy link
Contributor

Adding DropEdge GCN model
Adding unit test for dropedge_gcn
Adding DropEdge GCN to examples
Modifying match.yaml to contain dropedge_gcn

@JiaYiLiJayee
Copy link
Contributor Author

bf65bf0ac6f1ed67fd2cb9b0fb94554
Internal Error in Black failed the check.

@cenyk1230
Copy link
Member

Hi @JiaYiLiJayee,
It works but the coverage decreases. Please help to increase the coverage.

@JiaYiLiJayee
Copy link
Contributor Author

@cenyk1230
image
Seems like the unit test from last merge failed?

@cenyk1230
Copy link
Member

@JiaYiLiJayee,
Sorry, I will try to fix it soon.

@JiaYiLiJayee
Copy link
Contributor Author

JiaYiLiJayee commented Dec 16, 2020 •
edited
Loading

@cenyk1230
is this okay?, I think merged new code decreased the coverage further. I added more test cases it dropped to 0.2%, before it was a drop of 0.1%.

@cenyk1230 cenyk1230 merged commit 293d581 into THUDM:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiaYiLiJayee @cenyk1230