Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daniel/test sets #6

Merged
merged 10 commits into from
Dec 19, 2022
Merged

Daniel/test sets #6

merged 10 commits into from
Dec 19, 2022

Conversation

daniel020403
Copy link
Collaborator

Description

Added tests for Sets and GSets.

pjaclark
pjaclark requested changes Nov 29, 2022
View reviewed changes
Copy link

@pjaclark pjaclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testGSet needs to try and remove an item and fail.

After checking it updated, do the same as testSet by removing user2, and having that fail as we'd expect.

@daniel020403
Copy link
Collaborator Author

daniel020403 commented Dec 1, 2022 •
edited

testGSet needs to try and remove an item and fail.

After checking it updated, do the same as testSet by removing user2, and having that fail as we'd expect.

Exception test for when removing an item from a GSet added.
@pjaclark

pjaclark
pjaclark reviewed Dec 9, 2022
View reviewed changes
src/test/java/com/basho/riak/client/api/commands/itest/ITestDatatype.java Show resolved Hide resolved
src/test/java/com/basho/riak/client/api/commands/itest/ITestDatatype.java Outdated
SetUpdate suRemoveItem = new SetUpdate().remove("user2");
UpdateSet updateRemove = new UpdateSet.Builder(location, suRemoveItem).withContext(ctx).build();
client.execute(updateRemove);
} catch (Exception e) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to IllegalArgumentException and let others through.

@pjaclark
Copy link

LGTM

Bob-The-Marauder
Bob-The-Marauder approved these changes Dec 19, 2022
View reviewed changes
Copy link

@Bob-The-Marauder Bob-The-Marauder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java is not my strong suit but everything looks ok to me as far as I can see.

@daniel020403 daniel020403 merged commit a5ca7ee into TI-Tokyo:develop Dec 19, 2022
@daniel020403 daniel020403 deleted the daniel/test-sets branch December 19, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bob-The-Marauder Bob-The-Marauder Bob-The-Marauder approved these changes

@pjaclark pjaclark pjaclark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daniel020403 @pjaclark @Bob-The-Marauder