Fix some issues about negative number and expression #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/mapper/exprmapper/expression/gocc/parser/actiontable.go # core/mapper/exprmapper/expression/gocc/parser/gototable.go # core/mapper/exprmapper/expression/gocc/parser/parser.go # core/mapper/exprmapper/expression/gocc/parser/productionstable.go
| @@ -117,6 +116,7 @@ ExprLiteral | |||
|
|
|||
| Literal | |||
| : Int <<direction.NewIntLit($0)>> | |||
| | "-"Int <<direction.NewNagtiveLit($1)>> | |||
There was a problem hiding this comment.
@lixingwang : what about negative floats?
There was a problem hiding this comment.
@vijaynalawade I missed float. pushed negative float supporting in PR.
vijaynalawade
approved these changes
Jan 7, 2019
fm-tibco
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
Fixes: #
What is the current behavior?
Have issue support expression like:
3-2, parser takes-2as a negative number rather than operator-and number2.What is the new behavior?
Correct BNF to take negative out of lexer which should be part of grammar.