Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Domestic and Addressables #54

Closed
djamesfar opened this issue Mar 9, 2021 · 1 comment · Fixed by #55
Closed

Refactor Domestic and Addressables #54

djamesfar opened this issue Mar 9, 2021 · 1 comment · Fixed by #55
Assignees
@djamesfar

Comments

@djamesfar
Copy link
Contributor

Refactor an Address model which will be polymorphic on various models (User, Company, Location), and a DomesticAddress which will have unique relations (Cart, Order, PlaceDetail, GMBDetail)
@djamesfar djamesfar self-assigned this Mar 9, 2021
@drewroberts
Copy link
Member

This is partly correct. Domestic Address (#19) has a one-to-many relationship with:

  • Address
  • Company
  • Location
  • Place Detail
  • GMB Detail

Address is a polymorphic relationship with:

  • User (Shipping & Billing)
  • Order (Shipping & Billing)
  • Cart (potential Shipping & Billing)

There may be other models. That will use either one of these. As you find them, ping this issue and I will let you know which one they should use. Thanks!

drewroberts added a commit that referenced this issue Mar 10, 2021
@drewroberts
Register policies & nova resources #54
1a8bd06
@drewroberts drewroberts linked a pull request Mar 10, 2021 that will close this issue
refactor Address, DomesticAddress, migrations #55
Merged
This was referenced Mar 10, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djamesfar djamesfar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor Address, DomesticAddress, migrations TIPOFF/addresses
2 participants
@djamesfar @drewroberts