Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policies, policy seeders and tests #14

Merged
merged 9 commits into from
Feb 11, 2021
Merged

Conversation

pdbreen
Copy link
Contributor

@pdbreen pdbreen commented Feb 10, 2021

No description provided.

@drewroberts drewroberts mentioned this pull request Feb 10, 2021
@drewroberts
Copy link
Member

Should I go ahead and move the permissions table migration to the tipoff/authorization package?

@pdbreen
Copy link
Contributor Author

pdbreen commented Feb 11, 2021

Added a PR for adding the migration to tipoff/authorization and moving the spatie/laravel-permission dependency to it.

@pdbreen
Copy link
Contributor Author

pdbreen commented Feb 11, 2021

If you agree w/keeping auth dependency explicit when needed, this is ready to go.

Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Patrick! 👾

@drewroberts drewroberts merged commit ff90be9 into main Feb 11, 2021
@drewroberts drewroberts deleted the pdbreen/feature/policy branch February 11, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants