Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Models should extend BaseModel #11

Merged
merged 1 commit into from
Feb 6, 2021
Merged

Models should extend BaseModel #11

merged 1 commit into from
Feb 6, 2021

Conversation

phuclh
Copy link
Contributor

@phuclh phuclh commented Feb 6, 2021

I make all models in this package extend BaseModel instead of Laravel Model.

drewroberts
drewroberts approved these changes Feb 6, 2021
View reviewed changes
Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🍯

@drewroberts drewroberts merged commit 9959bc8 into main Feb 6, 2021
@drewroberts drewroberts deleted the omnia/feature/models-should-extend-base-model branch February 6, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewroberts drewroberts drewroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phuclh @drewroberts