-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Routes #48 #54
Add Routes #48 #54
Conversation
return [ | ||
|
||
//This stores the forms that this package will generate routes for. | ||
'active' => [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I figured just adding an array that stores a list of active forms, you can reference routes/api.php
to see how form routes could then be dynamically generated. This is subject to change.
Need to figure out what https://github.com/tger/tger/blob/dev/app/Http/Controllers/Web/Site/Pages/ContactController.php#L22 @drewroberts any updates on what these relate to? |
{ | ||
public function __invoke(Request $request, Market $market = null, Location $location = null) | ||
{ | ||
$current = getCurrentMarket($request); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be moved to locations. If there, need to reference it?
return redirect()->to($market->contact_path); | ||
} | ||
|
||
setCurrentMarket($request, $market); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be moved to locations. If there, need to reference it?
]); | ||
} | ||
|
||
// Send to correct market if somehow they get to a URL with a different market than where the location belongs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drewroberts I'm assuming this is associated with TIPOFF/locations#85?
return redirect()->to($current->contact_path); | ||
} | ||
|
||
$image = Image::find(40)->url; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to figure out what this variable is associated with
Going to close this and re-open a new request once the process of routing & views is mored defined in a few other packages. |
This PR will encompass all of the requirements listed in #48