Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyword Types #16

Closed
drewroberts opened this issue Feb 23, 2021 · 4 comments
Closed

Keyword Types #16

drewroberts opened this issue Feb 23, 2021 · 4 comments
Assignees
@drewroberts

Comments

@drewroberts
Copy link
Member

Keyword Types include:

  • Branded
  • Generic
  • Local

Keywords will have a one-to-many relationship with Keyword Types.
@drewroberts drewroberts mentioned this issue Feb 23, 2021
Open
@drewroberts drewroberts self-assigned this Feb 23, 2021
drewroberts added a commit that referenced this issue Feb 23, 2021
@drewroberts
Create stub migration for keyword types #16
85dd9d7
chx2 added a commit that referenced this issue Feb 24, 2021
@chx2
Add Model, Factory, Policy, and Tests for #16
02ef82a
@arwaawan3
Copy link
Contributor

Keyword Types include:

  • Branded
  • Generic
  • Local

Keywords will have a one-to-many relationship with Keyword Types.

Would Branded, Generic and Local be child classes of KeywordType?

@drewroberts
Copy link
Member Author

Yes, classes may be a better approach. Those are the only 3 types, so we may not need a database table for it.

drewroberts added a commit that referenced this issue Feb 25, 2021
@drewroberts
Remove keyword types relationship #16
a3bca6b
drewroberts added a commit that referenced this issue Feb 25, 2021
@drewroberts
Delete keyword type migration #16
f407cee
drewroberts added a commit that referenced this issue Feb 25, 2021
@drewroberts
Delete keyword types factory #16
03e813d
drewroberts added a commit that referenced this issue Feb 25, 2021
@drewroberts
Delete keyword type model #16
2ce8aed
drewroberts added a commit that referenced this issue Feb 25, 2021
@drewroberts
Remove keyword type #16
278e1d9
drewroberts added a commit that referenced this issue Feb 25, 2021
@drewroberts
Delete keyword type model test #16
f5b9fd9
drewroberts added a commit that referenced this issue Feb 25, 2021
@drewroberts
Remove keyword type permissions #16
6f624e4
drewroberts added a commit that referenced this issue Feb 25, 2021
@drewroberts
Add sting type field for keywords #16 #17
9438dfc
drewroberts added a commit that referenced this issue Feb 25, 2021
@drewroberts
Remove keyword type permissions #16
cd2ac17
drewroberts added a commit that referenced this issue Feb 25, 2021
@drewroberts
Merge pull request #27 from tipoff/omnia/feature/#76_seo_issues
cc900e2 
Remove Keyword Types Model #16 #26
@drewroberts
Copy link
Member Author

I'm working on an implementation for keyword types that will be in the next PR

drewroberts added a commit that referenced this issue Feb 25, 2021
@drewroberts
Add keyword types #16 to keywords #17
63e8f17
drewroberts added a commit that referenced this issue Feb 25, 2021
@drewroberts
Merge pull request #28 from tipoff/drewroberts/feature/16-keyword-types
ceb4405 
Keyword Types #16
@arwaawan3
Copy link
Contributor

Ok 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewroberts drewroberts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drewroberts @arwaawan3